[admin][broker] Fix force delete subscription not working#22423
Merged
Conversation
nodece
approved these changes
Apr 4, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Apr 8, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Apr 8, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
(cherry picked from commit 110add0)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
(cherry picked from commit 110add0)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
(cherry picked from commit 110add0)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
(cherry picked from commit 110add0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
(cherry picked from commit 110add0)
|
Adding to what @fecet said, the Javadoc is clearly misleading, be it on close() or unsubscribe(), which both, clearly state that with the force flag it closes both the producers and consumers connected to said topic. (pulsar-client 3.2.2, broker 3.3.2) Which is does not since if there is a consumer connected, the topic and subscription get auto-recreated, and unfortunately we cannot disable the auto-creation through the broker.conf since we need it for another use case. |
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22404
Motivation
Fix force delete subscription not working on persistent topics.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: