[fix][broker][admin] Fix cannot update properties on NonDurable subscription.#22411
Merged
Merged
Conversation
Member
Author
|
@lhotari @codelipenghui @mattisonchao @eolivelli @Technoboy- Could you please take a look? |
lhotari
requested changes
Apr 4, 2024
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22411 +/- ##
============================================
+ Coverage 73.57% 73.81% +0.23%
+ Complexity 32624 32402 -222
============================================
Files 1877 1885 +8
Lines 139502 139818 +316
Branches 15299 15319 +20
============================================
+ Hits 102638 103203 +565
+ Misses 28908 28636 -272
- Partials 7956 7979 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2024
…ription. (apache#22411) (cherry picked from commit 902728e) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java (cherry picked from commit 7cd0924)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 8, 2024
…ription. (apache#22411) (cherry picked from commit 902728e) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java (cherry picked from commit 7cd0924)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22402
Motivation
Fix cannot update properties on NonDurable subscription.
Reproduce step:
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: