[fix][broker] Fix ResourceGroup report local usage#22340
Merged
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Member
Author
|
/pulsarbot rerun-failure-checks |
nodece
added a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5)
nodece
added a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5)
nodece
added a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5)
nodece
added a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5)
4 tasks
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 15, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0b2b6d5) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
org.apache.pulsar.broker.resourcegroup.ResourceQuotaCalculator#needToReportLocalUsagedetermine whether sending the current report of local usage can be suppressed (to reduce network communication), when returns true, we need to report the local usage to resourcegroup topic and reset some status, but now we always reset that, please see https://github.com/apache/pulsar/blob/v3.0.3/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java#L452-L457Now the
maxIntervalForSuppressingReportsMSecsis in seconds, and is used to comparing with milliseconds, so the local usage is always reported, please see https://github.com/apache/pulsar/blob/v3.0.3/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceQuotaCalculatorImpl.java#L99-L103Modifications
usedLocallySinceLastReport,totalUsedLocally,lastResourceUsageFillTimeMSecsSinceEpochafterneedToReportLocalUsagereturns true.maxIntervalForSuppressingReportsMSecsto milliseconds from seconds.Documentation
docdoc-requireddoc-not-neededdoc-complete