[fix][broker] Check cursor state before adding it to the `waitingCursors` by Technoboy- · Pull Request #22191 · apache/pulsar

Technoboy- · 2024-03-04T13:47:12Z

Motivation

The root cause :
There is a race condition between the consumer.close and checkForNewEntries.
When the consumer is closed, the waitingCursor may be empty.

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java

Lines 298 to 313 in ccc2ea6

    
           public synchronized void removeConsumer(Consumer consumer, boolean isResetCursor) throws BrokerServiceException { 
        
               cursor.updateLastActive(); 
        
               if (dispatcher != null) { 
        
                   dispatcher.removeConsumer(consumer); 
        
               } 
        
               // preserve accumulative stats form removed consumer 
        
               ConsumerStatsImpl stats = consumer.getStats(); 
        
               bytesOutFromRemovedConsumers.add(stats.bytesOutCounter); 
        
               msgOutFromRemovedConsumer.add(stats.msgOutCounter); 
        
               if (dispatcher != null && dispatcher.getConsumers().isEmpty()) { 
        
                   deactivateCursor(); 
        
                   topic.getManagedLedger().removeWaitingCursor(cursor); 
        
                   if (!cursor.isDurable()) {

.
Then after executing line-311, the cursor was added to waitingCursor.

Documentation

doc
doc-required
doc-not-needed
doc-complete

lhotari

LGTM, good work @Technoboy-

…ors` (#22191) (cherry picked from commit b702d44)

…ors` (apache#22191)

lhotari · 2024-04-09T12:05:19Z

#22454 should be cherry-picked too if this is cherry-picked since this PR introduced a regression #22435 which is fixed by #22454.

…ors` (#22191) (cherry picked from commit b702d44)

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

…ors` (apache#22191)

Check cursor state before adding it to the waitingCursors

040ac89

Technoboy- self-assigned this Mar 4, 2024

Technoboy- added the ready-to-test label Mar 4, 2024

Technoboy- added this to the 3.3.0 milestone Mar 4, 2024

Technoboy- added release/3.0.4 release/3.1.4 release/3.2.2 release/2.10.7 release/2.11.5 labels Mar 4, 2024

github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Mar 4, 2024

lhotari approved these changes Mar 4, 2024

View reviewed changes

dao-jun approved these changes Mar 5, 2024

View reviewed changes

Technoboy- added 3 commits March 6, 2024 14:33

improve test

c051cf8

fix

f76601d

fix

91ec7b9

lhotari merged commit b702d44 into apache:master Mar 27, 2024

lhotari added the cherry-picked/branch-3.0 label Mar 27, 2024

lhotari pushed a commit that referenced this pull request Mar 27, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

ba8ff27

…ors` (#22191) (cherry picked from commit b702d44)

lhotari pushed a commit that referenced this pull request Mar 27, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

622c87d

…ors` (#22191) (cherry picked from commit b702d44)

lhotari added the cherry-picked/branch-3.2 label Mar 27, 2024

Technoboy- added a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

3dea6a2

…ors` (apache#22191)

KannarFr mentioned this pull request Apr 4, 2024

[Bug] Consumer Stops Receiving Messages with Large Backlogs Post-Processing #22435

Closed

3 tasks

lhotari mentioned this pull request Apr 8, 2024

[fix][broker] Fix consumer stops receiving messages when with large backlogs processing #22454

Merged

4 tasks

lhotari pushed a commit that referenced this pull request Apr 9, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

afe7bd5

…ors` (#22191) (cherry picked from commit b702d44)

lhotari added the cherry-picked/branch-3.1 label Apr 9, 2024

mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

8682575

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

0d6f128

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

7d3675b

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

51fab32

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

95c0675

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

lhotari mentioned this pull request May 3, 2024

[Bug] After updating broker from 3.0.3 to 3.0.4, reader cannot receive new messages from compacted topics. #22634

Closed

3 tasks

pgier pushed a commit to pgier/pulsar that referenced this pull request Aug 23, 2024

[fix][broker] Check cursor state before adding it to the `waitingCurs…

8fefb62

…ors` (apache#22191) (cherry picked from commit b702d44) (cherry picked from commit ba8ff27)

hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025

[fix][broker] Check cursor state before adding it to the `waitingCurs…

23a3f06

…ors` (apache#22191)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix][broker] Check cursor state before adding it to the `waitingCursors`#22191

[fix][broker] Check cursor state before adding it to the `waitingCursors`#22191
lhotari merged 4 commits into
apache:masterfrom
Technoboy-:fix-22157

Technoboy- commented Mar 4, 2024

Uh oh!

lhotari left a comment

Uh oh!

lhotari commented Apr 9, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public synchronized void removeConsumer(Consumer consumer, boolean isResetCursor) throws BrokerServiceException {
	cursor.updateLastActive();
	if (dispatcher != null) {
	dispatcher.removeConsumer(consumer);
	}

	// preserve accumulative stats form removed consumer
	ConsumerStatsImpl stats = consumer.getStats();
	bytesOutFromRemovedConsumers.add(stats.bytesOutCounter);
	msgOutFromRemovedConsumer.add(stats.msgOutCounter);

	if (dispatcher != null && dispatcher.getConsumers().isEmpty()) {
	deactivateCursor();
	topic.getManagedLedger().removeWaitingCursor(cursor);

	if (!cursor.isDurable()) {

Conversation

Technoboy- commented Mar 4, 2024

Motivation

Documentation

Uh oh!

lhotari left a comment

Choose a reason for hiding this comment

Uh oh!

lhotari commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lhotari commented Apr 9, 2024 •

edited

Loading