Skip to content

[fix][monitor] Fix the incorrect metrics name #21981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 2 commits into from
Nov 4, 2025
Merged

[fix][monitor] Fix the incorrect metrics name #21981

lhotari merged 2 commits into from
Nov 4, 2025

Conversation

@crossoverJie
Copy link
Member

@crossoverJie crossoverJie commented Jan 28, 2024

Motivation

Fix the incorrect metrics name.

Reference links:
#21766 (comment)
https://github.com/apache/bookkeeper/releases/tag/release-4.16.0

Modifications

bookkeeper_server_ADD_ENTRY_REQUEST->bookkeeper_server_ADD_ENTRY
bookkeeper_server_READ_ENTRY_REQUEST->bookkeeper_server_READ_ENTRY

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 28, 2024
@Technoboy- Technoboy- requested review from hangc0276 and zymap January 28, 2024 16:16
@Technoboy- Technoboy- added this to the 3.3.0 milestone Jan 28, 2024
congbobo184
congbobo184 reviewed Jan 30, 2024
View reviewed changes
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari closed this Oct 9, 2024
@lhotari lhotari reopened this Oct 9, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
@coderzc coderzc modified the milestones: 4.1.0, 4.2.0 Sep 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.27%. Comparing base (676ba07) to head (73ef124).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21981       +/-   ##
=============================================
+ Coverage     38.56%   74.27%   +35.71%     
- Complexity    13262    33903    +20641     
=============================================
  Files          1856     1913       +57     
  Lines        145287   149501     +4214     
  Branches      16877    17371      +494     
=============================================
+ Hits          56025   111037    +55012     
+ Misses        81696    29611    -52085     
- Partials       7566     8853     +1287
Flag Coverage Δ
inttests 26.16% <ø> (-0.02%) ⬇️
systests 22.67% <ø> (-0.09%) ⬇️
unittests 73.81% <ø> (+39.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1412 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit b758283 into apache:master Nov 4, 2025
51 checks passed
lhotari added a commit that referenced this pull request Nov 4, 2025
@crossoverJie @lhotari
[fix][monitor] Fix the incorrect metrics name (#21981)
645f233 
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
(cherry picked from commit b758283)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@crossoverJie @lhotari @ganesh-ctds
[fix][monitor] Fix the incorrect metrics name (apache#21981)
f2c097b 
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
(cherry picked from commit b758283)
(cherry picked from commit 645f233)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2025
@crossoverJie @lhotari @srinath-ctds
[fix][monitor] Fix the incorrect metrics name (apache#21981)
354c517 
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
(cherry picked from commit b758283)
(cherry picked from commit 645f233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@congbobo184 congbobo184 congbobo184 left review comments

@lhotari lhotari lhotari approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@zymap zymap Awaiting requested review from zymap

Assignees

@crossoverJie crossoverJie

Labels

cherry-picked/branch-4.0 doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/4.0.8

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@crossoverJie @codecov-commenter @lhotari @congbobo184 @Technoboy- @coderzc