[fix][broker] Fixed the ExtensibleLoadManagerImpl internal system getTopic failure when the leadership changes#21764
Merged
lhotari merged 2 commits intoDec 20, 2023
Conversation
…ic getTopic failure when the leadership changes
2 tasks
Contributor
|
LGTM! |
Demogorgon314
approved these changes
Dec 20, 2023
lhotari
reviewed
Dec 20, 2023
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21764 +/- ##
============================================
+ Coverage 72.94% 73.43% +0.49%
- Complexity 32579 32786 +207
============================================
Files 1897 1897
Lines 140627 140647 +20
Branches 15486 15489 +3
============================================
+ Hits 102581 103288 +707
+ Misses 29974 29285 -689
- Partials 8072 8074 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
@heesung-sn Can you help cherry-pick this PR to |
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Dec 25, 2023
…Topic failure when the leadership changes (apache#21764)
1 task
Contributor
Author
|
Raised a cherry-pick PR here. |
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Dec 26, 2023
…Topic failure when the leadership changes (apache#21764)
Technoboy-
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Dec 27, 2023
…Topic failure when the leadership changes (apache#21764)
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jan 4, 2024
…Topic failure when the leadership changes apache#21764 (apache#21801)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 4, 2024
…Topic failure when the leadership changes apache#21764 (apache#21801) (cherry picked from commit 39b69a3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 8, 2024
…Topic failure when the leadership changes apache#21764 (apache#21801) (cherry picked from commit 39b69a3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After this fix, #21729, we need to recreate the non-persistent internal system topics when the leadership changes because we disabled the auto-creation of the non-persistent internal system topics.
Also, the non-persistent consumers and producers might be in a closed state, as they could receive
TopicNotFoundExceptionwhen the new leader broker has not created the internal topics yet. To cover this case, we need to update the leader and follower role change logic to be more idempotent.Modifications
Verifying this change
ExtensibleLoadManager.testIsolationPolicy test was flaky because of the this issue.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: heesung-sohn#55