[feat][client] Introduce Refresh API in the TableView#21417
Merged
Conversation
BewareMyPower
requested changes
Oct 23, 2023
BewareMyPower
left a comment
Contributor
There was a problem hiding this comment.
Remove meaningless lines
codelipenghui
requested changes
Oct 26, 2023
15 tasks
1. Add refresh API. 2. Add a linkedHashMap storing the refresh request. 2.1 Add request when refresh 2.2 Complete request when read completely. 2.3 Complete request exceptionally when reader close. 3. Add a map storing the current read position. 4. Check the current read position when building new refresh request.
…d `testRefreshAPI`.
3b03fad to
89e5c76
Compare
BewareMyPower
requested changes
Mar 11, 2024
BewareMyPower
approved these changes
Mar 11, 2024
Contributor
|
@codelipenghui Could you take a second review again? |
dao-jun
approved these changes
Mar 11, 2024
codelipenghui
approved these changes
Mar 15, 2024
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21417 +/- ##
============================================
+ Coverage 73.57% 73.64% +0.06%
+ Complexity 32624 32258 -366
============================================
Files 1877 1887 +10
Lines 139502 139436 -66
Branches 15299 15292 -7
============================================
+ Hits 102638 102681 +43
+ Misses 28908 28820 -88
+ Partials 7956 7935 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Master apache#21271 ### Motivation The proposal will introduce a new API to refresh the table view with the latest written data on the topic, ensuring that all subsequent reads are based on the refreshed data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master #21271
Motivation
The proposal will introduce a new API to refresh the table view with the latest written data on the topic, ensuring that all subsequent reads are based on the refreshed data.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: