[improve][io] Use SinkContext.fatal in elastic search connector
#21204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need the `checkFailed` to make the ElasticSearchClient more robust.
nicoloboschi
requested changes
Sep 25, 2023
...-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClient.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #21204 +/- ##
=============================================
+ Coverage 36.80% 73.21% +36.41%
- Complexity 12195 32469 +20274
=============================================
Files 1698 1887 +189
Lines 130396 140157 +9761
Branches 14253 15428 +1175
=============================================
+ Hits 47988 102612 +54624
+ Misses 76079 29454 -46625
- Partials 6329 8091 +1762
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nicoloboschi
approved these changes
Sep 25, 2023
liangyuanpeng
pushed a commit
to liangyuanpeng/pulsar
that referenced
this pull request
Oct 11, 2023
…ache#21204) ### Motivation We have introduced the `SinkContext.fatal` method in apache#21143 This PR use this fatal method to handle the elastic sink connector exception correctly. ### Modifications - Use `SinkContext.fatal` to throw connector exception - Add state to the ElasticSearchClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have introduced the
SinkContext.fatalmethod in #21143This PR use this fatal method to handle the elastic sink connector exception correctly.
Modifications
SinkContext.fatalto throw connector exceptionVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: