[improve][pip] PIP-300: Add custom dynamic configuration for plugins#21127
Merged
Conversation
poorbarcode
approved these changes
Sep 11, 2023
liangyepianzhou
approved these changes
Sep 26, 2023
liudezhi2098
approved these changes
Oct 7, 2023
Member
Author
|
PIP has been passed. |
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Dec 12, 2023
### Motivation See [PIP-300](apache#21127) ### Modifications Implement `registerCustomDynamicConfiguration`, which just adds a customized key to `dynamicConfigurationMap` so that updating such a key will be possible. The value is a `ConfigField` object whose `Field` field is null. Add `testUpdateCustomDynamicConfiguration` to verify it works. It should be noted the implementation is slightly different from the original proposal, which also does not express the design clearly.
4 tasks
nodece
commented
Dec 13, 2023
| } | ||
| try { | ||
| ServiceConfiguration.class.getDeclaredField(key); | ||
| throw new IllegalArgumentException("Only register custom configuration"); |
Member
Author
There was a problem hiding this comment.
I accidentally copied the wrong code, this check is meaningless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
docdoc-requireddoc-not-neededdoc-complete