Add LoadBalancer and OwnershipCache factory to support dual write/read to local_zk and data_zk #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration and ledger-metadata separately
…d to local_zk and data_zk
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
…nsform result to str (apache#208)
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#208 This PR ports Kafka's `SaslServerAuthenticator` into KoP with some limits: - Don't handle authentication corner cases for the Kafka Client 0.9.0.x, it's too troublesome and KoP doesn't support Kafka Client 0.9.0.x now. - Don't handle `SaslHandshakeRequest` v0 because this request has no header that it takes a lot of efforts to refactor current code and test. - Keep the old authentication way, i.e. user pass a `username` field to represent the namespace and a `data` field to represent the token, then Pulsar broker will use JWT authentication to do the actual authentication. See `docs/security.md` for details. - Add a unit test to cover the case that client doesn't configure authentication. More works to do: - Currently it just does a simple check for permissions in the authentication step. The authorization should be performed before each request is processed. - The authenticator exposes a getter for `AuthenticationState`, the `isExpired` method should be called to check if the token is expired and trigger the reconnection for clients.
Member
|
This PR is evidently stale or abandoned. Reopen if this is not so. |
|
@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As per #196: If pulsar migrates from single-zk ensemble to multiple zk- ensemble to store cluster-management and ledger-metadata separately, in this transition it requires OwnershipCache to manage
namespace-bundle ownershipin both the zookeeper in an atomic manner.Modifications
namespace-bundle ownershipandloadReport.Note:
It contains two commits:
(so, this PR depends on Support multiple zookeeper quorum to store cluster-management-configu… #196 to go first)
Result
It will not change existing functionality and provide a way to manage
bundle-ownershipandloadReportin multiple-zk ensemble.