[fix][test] Fix flaky PersistentSubscriptionTest#20434
Merged
lhotari merged 3 commits intoMay 31, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20434 +/- ##
============================================
- Coverage 72.92% 72.89% -0.04%
+ Complexity 31897 31868 -29
============================================
Files 1865 1865
Lines 138439 138443 +4
Branches 15192 15192
============================================
- Hits 100953 100914 -39
- Misses 29474 29503 +29
- Partials 8012 8026 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
May 31, 2023
lhotari
added a commit
that referenced
this pull request
Jul 13, 2023
(cherry picked from commit 242758d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19396
Motivation
PersistentSubscriptionTest.setup is flaky because Mockito isn't thread safe.
Modifications
Replace the usage of Mockito for setting the TransactionBufferProvider and TransactionPendingAckStoreProvider
in the test.
Documentation
docdoc-requireddoc-not-neededdoc-complete