[improve][broker] Change limitStatsLogging config default value to true#20409
Merged
Technoboy- merged 1 commit intoMay 31, 2023
Merged
Conversation
hangc0276
approved these changes
May 30, 2023
hangc0276
left a comment
Contributor
There was a problem hiding this comment.
We don't expose the bookie client metrics to Prometheus and exposing the bookie client channel level metrics wast a lot of resources. We can disable the channel level metric by default.
Contributor
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
May 30, 2023
Technoboy-
left a comment
Contributor
There was a problem hiding this comment.
We only need to keep this change in the master branch, no need to cherry pick to other branches, right ? @hangc0276
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20409 +/- ##
============================================
+ Coverage 72.45% 72.93% +0.48%
+ Complexity 31898 31888 -10
============================================
Files 1852 1864 +12
Lines 138227 138416 +189
Branches 15175 15188 +13
============================================
+ Hits 100150 100955 +805
+ Misses 30098 29450 -648
- Partials 7979 8011 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
zymap
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since apache/bookkeeper#3719 has set limitStatsLogging config default true in bookie, it is better to also set it default true in broker config.
Verifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: TakaHiR07#8