Skip to content

BP-60:Change PCBC limitStatsLogging default value to true#3719

Merged
hangc0276 merged 2 commits into
apache:masterfrom
wenbingshen:wenbing/disablePCBCMetrics
Jan 11, 2023
Merged

BP-60:Change PCBC limitStatsLogging default value to true#3719
hangc0276 merged 2 commits into
apache:masterfrom
wenbingshen:wenbing/disablePCBCMetrics

Conversation

@wenbingshen

Copy link
Copy Markdown
Member

Motivation

Fixes #3718

@wenbingshen

Copy link
Copy Markdown
Member Author

rerun failure checks

@horizonzy horizonzy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the BP?
BP needs to wait for the vote to be completed before merging
@eolivelli @dlg99

@dlg99 dlg99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenbingshen

Copy link
Copy Markdown
Member Author

is this the BP? BP needs to wait for the vote to be completed before merging @eolivelli @dlg99

@StevenLuMT PTAL. Thanks.
@eolivelli and @dlg99 have agreed to this change.

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 merged commit 49ca9fe into apache:master Jan 11, 2023
@wenbingshen wenbingshen deleted the wenbing/disablePCBCMetrics branch January 11, 2023 07:47
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BP-60:Change PCBC limitStatsLogging default value to true

5 participants