Skip to content

[feat][broker]PIP-255 Part-1: Add listener interface for namespace service#20406

Merged
Technoboy- merged 7 commits into
apache:masterfrom
hleecs:master
Jun 1, 2023
Merged

[feat][broker]PIP-255 Part-1: Add listener interface for namespace service#20406
Technoboy- merged 7 commits into
apache:masterfrom
hleecs:master

Conversation

@hleecs

@hleecs hleecs commented May 26, 2023

Copy link
Copy Markdown

PIP: #19806

Motivation

Modifications

In PIP-219, we want to make the partition assignment strategy pluggable.
First, we need to add listener interface for namespace service

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

Matching PR in forked repository

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label May 26, 2023

@315157973 315157973 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented May 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #20406 (5d9fe29) into master (f0e97f4) will increase coverage by 0.47%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20406      +/-   ##
============================================
+ Coverage     72.45%   72.92%   +0.47%     
- Complexity    31898    31904       +6     
============================================
  Files          1852     1867      +15     
  Lines        138227   138486     +259     
  Branches      15175    15202      +27     
============================================
+ Hits         100150   100989     +839     
+ Misses        30098    29489     -609     
- Partials       7979     8008      +29     
Flag Coverage Δ
inttests 24.14% <6.66%> (-0.03%) ⬇️
systests 24.94% <6.66%> (?)
unittests 72.21% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache/pulsar/broker/namespace/NamespaceService.java 69.73% <73.33%> (-0.20%) ⬇️

... and 172 files with indirect coverage changes

@Technoboy- Technoboy- added this to the 3.1.0 milestone May 29, 2023
@Technoboy- Technoboy- added type/feature The PR added a new feature or issue requested a new feature area/broker labels Jun 1, 2023
@Technoboy- Technoboy- merged commit 5e6e6ce into apache:master Jun 1, 2023
@RobertIndie

Copy link
Copy Markdown
Member

This is a feature PR and introduces a new interface. Why do we cherry-pick it to branch-3.0? @Technoboy-

Technoboy- added a commit to Technoboy-/pulsar that referenced this pull request Jul 10, 2023
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 13, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1 type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants