[improve][broker] Do not expose bucketDelayedIndexStats#20383
Merged
Technoboy- merged 1 commit intoMay 31, 2023
Conversation
mattisonchao
approved these changes
May 31, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20383 +/- ##
=============================================
+ Coverage 36.89% 72.96% +36.07%
- Complexity 12053 31934 +19881
=============================================
Files 1687 1867 +180
Lines 128826 138500 +9674
Branches 14013 15195 +1182
=============================================
+ Hits 47528 101054 +53526
+ Misses 75040 29442 -45598
- Partials 6258 8004 +1746
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
May 31, 2023
RobertIndie
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit 9f93af3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
bucketDelayedIndexStatsis an internal statistic, we don't should expose to the user.Modifications
Add the @JsonIgnore annotation to the above fields.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: