[fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat#19942
Merged
Merged
Conversation
Member
|
It seems that line-298 also needs to be changed. |
Contributor
|
I'm not sure why need to use the symbol |
Contributor
Author
|
Hi @gaoran10
Good idea, already fixed |
Contributor
Author
fixed, Thanks |
coderzc
approved these changes
Mar 28, 2023
congbobo184
approved these changes
Mar 28, 2023
Technoboy-
approved these changes
Mar 28, 2023
poorbarcode
added a commit
that referenced
this pull request
Mar 29, 2023
…ioned-topic stat (#19942) ### Motivation Pulsar will merge the variable `PartitionedTopicStatsImpl.replication[x].connected` by the way below when we call `pulsar-admin topics partitioned-stats` ``` java this.connected = this.connected & other.connected ``` But the variable `connected` of `PartitionedTopicStatsImpl.replication` is initialized `false`, so the expression `this.connected & other.connected` will always be `false`. Then we will always get the value `false` if we call `pulsar-admin topics partitioned-stats`. ### Modifications make the variable `` of `PartitionedTopicStatsImpl` is initialized `true` (cherry picked from commit 9fc0b5e)
poorbarcode
added a commit
that referenced
this pull request
Mar 29, 2023
…ioned-topic stat (#19942) ### Motivation Pulsar will merge the variable `PartitionedTopicStatsImpl.replication[x].connected` by the way below when we call `pulsar-admin topics partitioned-stats` ``` java this.connected = this.connected & other.connected ``` But the variable `connected` of `PartitionedTopicStatsImpl.replication` is initialized `false`, so the expression `this.connected & other.connected` will always be `false`. Then we will always get the value `false` if we call `pulsar-admin topics partitioned-stats`. ### Modifications make the variable `` of `PartitionedTopicStatsImpl` is initialized `true` (cherry picked from commit 9fc0b5e)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2023
…ioned-topic stat (apache#19942) ### Motivation Pulsar will merge the variable `PartitionedTopicStatsImpl.replication[x].connected` by the way below when we call `pulsar-admin topics partitioned-stats` ``` java this.connected = this.connected & other.connected ``` But the variable `connected` of `PartitionedTopicStatsImpl.replication` is initialized `false`, so the expression `this.connected & other.connected` will always be `false`. Then we will always get the value `false` if we call `pulsar-admin topics partitioned-stats`. ### Modifications make the variable `` of `PartitionedTopicStatsImpl` is initialized `true` (cherry picked from commit 9fc0b5e) (cherry picked from commit 4f15792)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar will merge the variable
PartitionedTopicStatsImpl.replication[x].connectedby the way below when we callpulsar-admin topics partitioned-statsBut the variable
connectedofPartitionedTopicStatsImpl.replicationis initializedfalse, so the expressionthis.connected & other.connectedwill always befalse.Then we will always get the value
falseif we callpulsar-admin topics partitioned-stats.Modifications
make the variable `` of
PartitionedTopicStatsImplis initialized `true`Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: