Skip to content

[fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.#19936

Merged
Technoboy- merged 1 commit into
apache:masterfrom
SeasonPanPan:fix_config_typo
Mar 28, 2023
Merged

[fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.#19936
Technoboy- merged 1 commit into
apache:masterfrom
SeasonPanPan:fix_config_typo

Conversation

@SeasonPanPan

Copy link
Copy Markdown
Contributor

Fix typo in ConsumerConfigurationData and ServiceConfiguration.

Motivation

Modifications

threashold --> threshold
aconsumer --> a consumer
createdif --> created if

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:
SeasonPanPan#1

@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Mar 27, 2023
@SeasonPanPan

Copy link
Copy Markdown
Contributor Author

@Anonymitaet Hi, this is the new PR of #19906, please check.

@RobertIndie

Copy link
Copy Markdown
Member

@SeasonPanPan Hi, actually you don't need to recreate a new PR when rebasing. Just rebase and push the branch.

@SeasonPanPan

Copy link
Copy Markdown
Contributor Author

@SeasonPanPan Hi, actually you don't need to recreate a new PR when rebasing. Just rebase and push the branch.

Thank you, I got it.

@Technoboy- Technoboy- added this to the 3.0.0 milestone Mar 28, 2023
@Technoboy- Technoboy- merged commit 7a99e74 into apache:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants