[fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.#19906
Closed
SeasonPanPan wants to merge 2 commits into
Closed
[fix][doc] fix typo in ConsumerConfigurationData and ServiceConfiguration.#19906SeasonPanPan wants to merge 2 commits into
SeasonPanPan wants to merge 2 commits into
Conversation
4 tasks
AnonHxy
approved these changes
Mar 23, 2023
RobertIndie
approved these changes
Mar 23, 2023
coderzc
approved these changes
Mar 23, 2023
lightzhao
approved these changes
Mar 23, 2023
maxsxu
approved these changes
Mar 23, 2023
Member
|
@SeasonPanPan please fill in this part in your PR description. Feel free to ping me to merge if all tests pass. |
Contributor
Author
Done |
Contributor
Author
|
@Anonymitaet I checked the CI error, it was not code reason, maybe it was the env problem. |
Member
|
@SeasonPanPan I've tried re-running the failed tests several times but they still failed. Have you tried pulling the latest master and then merging? |
Contributor
Author
|
@Anonymitaet I've pushed a new PR for #19906 |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix typo in ConsumerConfigurationData and ServiceConfiguration.
Motivation
Modifications
threashold --> threshold
aconsumer --> a consumer
createdif --> created if
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
SeasonPanPan#1