[fix][broker] fix can not revoke permission after update topic partition#17393
Merged
Conversation
Contributor
Author
|
This is the first PR only fix can not revoke permission problem. You can take a look. @michaeljmarshall @nodece |
michaeljmarshall
approved these changes
Sep 2, 2022
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
LGTM. This is a very clean solution.
nodece
approved these changes
Sep 2, 2022
2 tasks
4 tasks
Member
|
@TakaHiR07 |
Contributor
Author
@mattisonchao I can help cherry-pick the relevant 2 pr to branch-2.9. |
congbobo184
pushed a commit
that referenced
this pull request
Nov 14, 2022
### Motivation cherry-pick #17393 to branch-2.9
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2022
…ion (apache#17393) * add unittest for revoke permission of topic after update topic partition * fix revoke permission of partition Co-authored-by: fanjianye <fanjianye@bigo.sg> (cherry picked from commit 8c4aad5) (cherry picked from commit 2d0190f)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
…ion (#17393) * add unittest for revoke permission of topic after update topic partition * fix revoke permission of partition Co-authored-by: fanjianye <fanjianye@bigo.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
related to #16768
Modifications
should not fail a request that attempts to remove permission from a partition of a topic that was not already granted permission
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)