Skip to content

[fix][flaky-test]AdminApi2Test.testDeleteNamespace #17157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 2 commits into from
Aug 19, 2022
Merged

[fix][flaky-test]AdminApi2Test.testDeleteNamespace #17157

codelipenghui merged 2 commits into from
Aug 19, 2022

Conversation

@poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Aug 18, 2022 •
edited
Loading

Fixes: #17111

Motivation

same as #17070, there have two race conditions:

  1. delete namespace and asynchronously create topic __change_event
  2. delete namespace and asynchronously create subscription __change_event/__compaction

Modifications

Make delete namespace after __change_event and __change_event/__compaction create finish.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@poorbarcode poorbarcode force-pushed the flaky/testDeleteNamespace branch from 94f9c5f to d74ce77 Compare August 18, 2022 09:15
@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 18, 2022
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Aug 18, 2022

/pulsarbot rerun-failure-checks

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 18, 2022
@codelipenghui codelipenghui reopened this Aug 18, 2022
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Aug 19, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit de6948c into apache:master Aug 19, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 21, 2022
Technoboy- pushed a commit that referenced this pull request Aug 21, 2022
@poorbarcode @Technoboy-
[fix][flaky-test]AdminApi2Test.testDeleteNamespace (#17157)
531888f
Jason918 pushed a commit that referenced this pull request Sep 4, 2022
@poorbarcode @Jason918
[fix][flaky-test]AdminApi2Test.testDeleteNamespace (#17157)
603ce86 
(cherry picked from commit de6948c)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Sep 16, 2022
@poorbarcode @nicoloboschi
[fix][flaky-test]AdminApi2Test.testDeleteNamespace (apache#17157)
5a12199 
(cherry picked from commit de6948c)
(cherry picked from commit 603ce86)
@poorbarcode poorbarcode deleted the flaky/testDeleteNamespace branch September 17, 2022 02:45
@poorbarcode poorbarcode mentioned this pull request Sep 29, 2022
Merged
4 tasks
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 8, 2022
congbobo184 pushed a commit that referenced this pull request Nov 30, 2022
@poorbarcode
[fix][flaky-test]AdminApi2Test.testDeleteNamespace (#17157)
ef3fa9e 
(cherry picked from commit de6948c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@poorbarcode poorbarcode

Labels

cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs release/2.9.4 release/2.10.2 type/flaky-tests

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

Flaky-test: AdminApi2Test.testDeleteNamespace

5 participants

@poorbarcode @Technoboy- @codelipenghui @Jason918 @congbobo184