Skip to content

Fixed stats buffer rotation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merlimat merged 1 commit into from
Sep 16, 2016
Merged

Fixed stats buffer rotation #17

merlimat merged 1 commit into from
Sep 16, 2016

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Sep 16, 2016

Motivation

  • After recent change, the buffer is not cleared after being rotated.
  • Removed race condition on rotation

Modifications

Access the stats buffer under read lock, since we are not relying on the buffer pool and refcounting anymore.

@yahoocla
Copy link

yahoocla commented Sep 16, 2016

CLA is valid!

@merlimat merlimat self-assigned this Sep 16, 2016
@merlimat merlimat added this to the 1.15 milestone Sep 16, 2016
@rdhabalia
Copy link
Contributor

rdhabalia commented Sep 16, 2016

👍 seems have merging issue.

@merlimat merlimat merged commit b2cbf4e into apache:master Sep 16, 2016
@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Sep 26, 2016
sijie pushed a commit to sijie/pulsar that referenced this pull request Mar 4, 2018
@srkukarni @sijie
Minor stuff (apache#17)
5b0ed1b 
* Create pulsar-functions module (#1)

* Create pulsar-functions module

* rename `sdk` package to `api`

* Added the first cut of the Java interface for Pulsar functions (#2)

* Added join interface to Spawner.
@firefeifei firefeifei mentioned this pull request Nov 2, 2020
Closed
@LutzWeischerFujitsu LutzWeischerFujitsu mentioned this pull request Mar 17, 2021
Closed
hangc0276 referenced this pull request in hangc0276/pulsar May 26, 2021
@jiazhai @sijie
Add test framework to be able to run unit test. (#17)
daa19e1 
This PR is based on 
[Produce request](streamnative/kop@a09a805), which is in PR #14, please review and merge that first.

changes:
- change to sn pulsar version, so we could call getter/setter for parent class in `KafkaBrokerService` and `KafkaService`. Or it is not able to do the mock in test framework.
- add test framework, 
- add a simple produce request test, and pass write test.
@xiaotongwang1 xiaotongwang1 mentioned this pull request Aug 4, 2021
Closed
Technoboy- referenced this pull request in Technoboy-/pulsar Aug 12, 2021
@Technoboy-
Fix [Broker Interceptor] Pulsar didn't respond error messages when hi…
4b44911 
…tting the resource limit (#17)
Technoboy- referenced this pull request in Technoboy-/pulsar Aug 12, 2021
@Technoboy-
Fix [Broker Interceptor] Pulsar didn't respond error messages when th…
9e65a8c 
…row InterceptException (#17)
@paladin-dalao paladin-dalao mentioned this pull request Jan 13, 2022
Closed
@ZHr-UChiHa ZHr-UChiHa mentioned this pull request Jun 3, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdhabalia rdhabalia rdhabalia approved these changes

Assignees

@merlimat merlimat

Labels

type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@merlimat @yahoocla @rdhabalia