[fix][common] Fix setManagedLedgerOffloadedReadPriority not work. #16436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Jul 7, 2022
codelipenghui
approved these changes
Jul 8, 2022
zymap
pushed a commit
to zymap/pulsar
that referenced
this pull request
Jul 11, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
…ache#16436) (cherry picked from commit 52f7f13) (cherry picked from commit d60928f)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16432
Motivation
It's named
managedLedgerDataReadPriorityin ServiceConfiguration , but namedmanagedLedgerOffloadedReadPriorityin OffloadPoliciesImpl. So when copy properties, it' can't set the right field and cause OffloadPoliciesImpl to use the default value.Documentation
doc-not-needed