[fix][client] Fix JDK17 compatibility issue#15964
Conversation
|
@merlimat Thanks for the review. Still waiting for another committer to review this patch. |
|
@lgxbslgx - thanks for your contribution! |
|
@michaeljmarshall Thanks for the review. |
Fixes apache#15349 ### Motivation When using the JDK17, pulsar-client throws exception `module java.base does not export sun.net to unnamed module`, it is good to fix it. ### Modifications Add `--add-opens java.base/sun.net=ALL-UNNAMED` to java option when using JDK17. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` (cherry picked from commit 9d16b91)
Fixes apache#15349 ### Motivation When using the JDK17, pulsar-client throws exception `module java.base does not export sun.net to unnamed module`, it is good to fix it. ### Modifications Add `--add-opens java.base/sun.net=ALL-UNNAMED` to java option when using JDK17. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Documentation Check the box below or label this PR directly. Need to update docs? - [x] `doc-not-needed` (cherry picked from commit 9d16b91)
|
After configuration, a warning will be reported: |
|
@yulin20010422 - it'd help if you provided more information about the system you're running. Would you mind opening a new ticket to discuss this further? Thanks. |
|
@michaeljmarshall -Thank you for your timely reply, my computer system is macOS13.4 version M1 chip. I will not have this warning when I use Win11 system. In addition, I will still report this warning when I add |
|
@yulin20010422 You can open an issue to record the details steps to reproduce this issue here: https://github.com/apache/pulsar/issues |
|
@BewareMyPower Thankyou,I submitted a new issue.https://github.com/apache/pulsar/issues/20994 |
Fixes #15349
Motivation
When using the JDK17, pulsar-client throws exception
module java.base does not export sun.net to unnamed module, it is good to fix it.Modifications
Add
--add-opens java.base/sun.net=ALL-UNNAMEDto java option when using JDK17.Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed