[Proxy & Client] Configure Netty DNS resolver to match JDK DNS caching setting, share DNS resolver instance in Proxy#15219
Merged
Conversation
- Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments
eolivelli
approved these changes
Apr 19, 2022
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
LGTM
this change affects also the Broker and the Function worker, that is any component that uses the Pulsar Client.
michaeljmarshall
approved these changes
Apr 19, 2022
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 20, 2022
…g setting, share DNS resolver instance in Proxy (apache#15219) - make Netty DNS resolver settings match the JDK DNS caching settings - with the exception that the max TTL is 60 seconds if DNS max TTL is the default (forever) - reuse the DNS resolver instance on the Proxy
codelipenghui
approved these changes
Apr 20, 2022
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…g setting, share DNS resolver instance in Proxy (apache#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2022
…g setting, share DNS resolver instance in Proxy (apache#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
…g setting, share DNS resolver instance in Proxy (apache#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
lhotari
added a commit
that referenced
this pull request
Apr 29, 2022
…g setting, share DNS resolver instance in Proxy (#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
lhotari
added a commit
that referenced
this pull request
Apr 29, 2022
…g setting, share DNS resolver instance in Proxy (#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
lhotari
added a commit
that referenced
this pull request
Apr 29, 2022
…g setting, share DNS resolver instance in Proxy (#15219) * Align Netty DNS resolver cache settings with Java DNS cache settings - Netty DNS resolver caches forever by default - this could cause problems with Kubernetes deployments * Share Netty DNSNameResolver in proxy * Remove overriding of ConnectionPool.close since it's not necessary * Address review comment: remove ProxyConnectionPool (cherry picked from commit 39b1862)
lhotari
added a commit
that referenced
this pull request
Jun 1, 2022
…g setting, share DNS resolver instance in Proxy (#15219) - make Netty DNS resolver settings match the JDK DNS caching settings - with the exception that the max TTL is 60 seconds if DNS max TTL is the default (forever) - reuse the DNS resolver instance on the Proxy (cherry picked from commit f5adc17)
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
By default, the Netty DNS resolver caches DNS entries until the max TTL for the DNS entry. This could be problematic if DNS resolution settings change more often than the max TTL.
Modifications