Integration tests for function-worker rebalance and drain operations. #13058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaushik-develop:Thanks for your contribution. For this PR, do we need to update docs? |
c97455e to
ebebfa1
Compare
jerrypeng
reviewed
Dec 1, 2021
|
|
||
| private List<Map<String, Collection<String>>> getFunctionAssignments() throws Exception | ||
| { | ||
| ContainerExecResult result = pulsarCluster.getAnyWorker().execCmd( |
Contributor
There was a problem hiding this comment.
The output of this puslar-admin cli call is suppose to be more human readable but not easy to parse. If you call the REST API, the response will be in json and easier to parse. Not a super big deal, just the parsing code will be much simpler.
jerrypeng
approved these changes
Dec 1, 2021
zeo1995
pushed a commit
to zeo1995/pulsar
that referenced
this pull request
Dec 1, 2021
* up/master: (75 commits) [website][upgrade]feat: website upgrade / docs migration - 2.5.1 Get Started/Concepts and Architecture/Pulsar Schema (apache#13030) Fix environment variable assignment in startup scripts (apache#13025) update 2.8.x (apache#13029) [Doc] add tips for Pulsar tools (apache#13044) Suggest to use tlsPort instead of deprecated TlsEnable (apache#13039) Integration tests for function-worker rebalance and drain operations. (apache#13058) fix(functions): missing runtime set in GoInstanceConfig (apache#13031) [pulsar-admin] Add get-replicated-subscription-status command for topic (apache#12891) [Broker] Consider topics in pulsar/system namespace as system topics (apache#13050) Fix typo: correct sizeUint to sizeUnit (apache#13040) fix-12894 (apache#12896) Don't attempt to delete pending ack store unless transactions are enabled (apache#13041) [Perf] Evaluate the current protocol version once (apache#13045) Fix Issue apache#12885, Unordered consuming case in Key_Shared subscription (apache#12890) [broker]Optimize topicMaxMessageSize with topic local cache. (apache#12830) [PIP-105] Part-2 Support pluggable entry filter in Dispatcher (apache#12970) [website] Modify admin-api-topic.md document (apache#12996) add missed import (apache#13037) [metadata] Add RocksdbMetadataStore (apache#12776) [C] Add pulsar_client_subscribe_multi_topics and pulsar_client_subscribe_pattern (apache#12965) ... # Conflicts: # site2/website-next/docusaurus.config.js # site2/website-next/versioned_sidebars/version-2.6.1-sidebars.json # site2/website-next/versions.json
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 2, 2021
…apache#13058) Co-authored-by: Kaushik Ghosh <kaushikg@splunk.com> (cherry picked from commit 6e3b736)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…apache#13058) Co-authored-by: Kaushik Ghosh <kaushikg@splunk.com>
Member
|
@kaushik-develop When submitting a PR, can you provide doc-related info (tick the box) in the PR description? So that Bot can recognize and label your PR correspondingly. Or else Bot labels your PR with You can check the instructions for doc labels here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Integration tests for function-worker rebalance and drain operations.
Modifications
Added integration tests for function-worker rebalance and drain.
Verifying this change
This change added tests and can be verified as follows:
mvn -B -ntp test -f tests/pom.xml -DintegrationTestSuiteFile=pulsar-process.xml -DintegrationTests -Dgroups=rebalance_drain
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
No