On multi-topic consumer, we shouldn't keep checking the partitioned metadata #10708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
May 26, 2021
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
Lgtm
I left a minor comment
| .collect(Collectors.toList()); | ||
| } else { | ||
| boolean isTopicBeingSubscribedForInOtherThread = this.topics.putIfAbsent(topicName, 1) != null; | ||
| boolean isTopicBeingSubscribedForInOtherThread = this.topics.putIfAbsent(topicName, 0) != null; |
Contributor
There was a problem hiding this comment.
Does it make sense to create a constant for this magic value?
Contributor
Author
There was a problem hiding this comment.
Good point. Added constant
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…etadata (apache#10708) * On multi-topic consumer, we shouldn't keep checking the partitioned metadata * Added NON_PARTITIONED constant * Removed assertion that is now invalid * Fixed handling of deleted partitioned topic * Fixed re-subscribing same topic
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…etadata (apache#10708) * On multi-topic consumer, we shouldn't keep checking the partitioned metadata * Added NON_PARTITIONED constant * Removed assertion that is now invalid * Fixed handling of deleted partitioned topic * Fixed re-subscribing same topic
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jun 30, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jun 30, 2021
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Jun 30, 2021
… partitioned metadata (apache#10708)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 1, 2021
…partitioned metadata (#11168) Pick #10708 to branch 2.7. ### Motivation When using a multi-topic consumer, either through the regex or by passing a list of topics, we are ending up checking the partitioned topic metadata every 1 min, even if the topics are not partitioned. We don't need to re-check that information if the topics are not partitioned. Also, this can be causing a lot of read traffic on ZK since we keep checking that "partitioned-metadata" that these topics don't have and, in 2.7, this information is not cached in brokers when the metadata is not found. ### Modifications When adding non-partitioned topics to the multi-topic consumer, use 0 for partitions when the topic is not partitioned in order to skip the periodic re-check of the partitions count.
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Nov 4, 2021
…etadata (apache#10708) * On multi-topic consumer, we shouldn't keep checking the partitioned metadata * Added NON_PARTITIONED constant * Removed assertion that is now invalid * Fixed handling of deleted partitioned topic * Fixed re-subscribing same topic
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…etadata (apache#10708) * On multi-topic consumer, we shouldn't keep checking the partitioned metadata * Added NON_PARTITIONED constant * Removed assertion that is now invalid * Fixed handling of deleted partitioned topic * Fixed re-subscribing same topic
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using a multi-topic consumer, either through the regex or by passing a list of topics, we are ending up checking the partitioned topic metadata every 1 min, even if the topics are not partitioned.
We don't need to re-check that information if the topics are not partitioned. Also, this can be causing a lot of read traffic on ZK since we keep checking that "partitioned-metadata" that these topics don't have and, in 2.7, this information is not cached in brokers when the metadata is not found.
Modifications
When adding non-partitioned topics to the multi-topic consumer, use 0 for partitions when the topic is not partitioned in order to skip the periodic re-check of the partitions count.