Skip to content

Fix schema type check issue when use always compatible strategy #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Apr 26, 2021
Merged

Fix schema type check issue when use always compatible strategy #10367

codelipenghui merged 1 commit into from
Apr 26, 2021
+92 −209

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Apr 25, 2021 •
edited
Loading

Related to #9797

Motivation

Fix schema type check issue when use always compatible strategy.

  1. For non-transitive strategy, only check schema type for the last schema
  2. For transitive strategy, check all schema's type
  3. Get schema by schema data should consider different schema types

Verifying this change

New unit tests added.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Apr 25, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Apr 25, 2021
@codelipenghui
Copy link
Contributor Author

codelipenghui commented Apr 25, 2021

@limingnihao Please help review.

eolivelli
eolivelli approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.
This is to be ported to 2.7.2, correct?

@codelipenghui
Copy link
Contributor Author

codelipenghui commented Apr 25, 2021

@eolivelli Yes, due to #9797 merged into branch-2.7. we need this fix in 2.7.2.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Apr 25, 2021
@codelipenghui codelipenghui merged commit 04f8c96 into apache:master Apr 26, 2021
@codelipenghui codelipenghui deleted the penghui/fix-always-compatible-type branch April 26, 2021 00:27
codelipenghui added a commit that referenced this pull request Apr 27, 2021
@codelipenghui
Fix schema type check issue when use always compatible strategy (#10367)
22ac4c8 
Related to #9797

Fix schema type check issue when use always compatible strategy.

1. For non-transitive strategy, only check schema type for the last schema
2. For transitive strategy, check all schema's type
3. Get schema by schema data should consider different schema types

(cherry picked from commit 04f8c96)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Apr 27, 2021
@Denovo1998 Denovo1998 mentioned this pull request Mar 8, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@eolivelli eolivelli eolivelli approved these changes

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@sijie sijie Awaiting requested review from sijie

@315157973 315157973 Awaiting requested review from 315157973

Assignees

@codelipenghui codelipenghui

Labels

cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.2 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@codelipenghui @merlimat @eolivelli