(#6067) - better all-docs perf tests #6067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Dec 24, 2016
| name: 'all-docs-skip-limit', | ||
| assertions: 1, | ||
| iterations: 50, | ||
| iterations: 10, |
Member
Author
There was a problem hiding this comment.
reduced iterations because the new tests is necessarily slower
This was referenced Dec 24, 2016
daleharvey
approved these changes
Dec 26, 2016
Contributor
daleharvey
left a comment
There was a problem hiding this comment.
Makes a lot more sense to do them sequentially
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better version of the
all-docsperf tests than the previous one.Previously, we were running 10 concurrent
allDocs()requests usingPromise.all(). In the new version, they are chained together and thus not concurrent.I believe it's a more accurate test to chain these together, because that's how people would actually use these APIs in the real world. For a pagination scenario, they would not do 10
allDocs()all at once but would rather do them one-at-a-time. Furthermore this actually has an impact on the measurements, because if we run all tasks together then the IDB engine can batch everything concurrently under the hood and make the results appear better than they are.