Looks like this causes errors in pouchdb-server. Might have to open a parallel pull req in express-pouchdb as well.

Not being able to identify errors by their name actually breaks quite a bit of the code. There are a lot of places where we check err.name === 'not_found', e.g. in upsert.js, setup.js, and create-view.js (in mapreduce).

I would much rather we have a single commit that fixes all the problems with non-JS-style errors rather than the piecemeal thing we've been doing so far.

I would like to do it in one swoop as well, but I doubt I will have time for that and those gigantic pulls that change every file tend to be very tricky.

Fair enough. Also there doesn't seem to be anywhere that we're trying to detect these particular errors. Let's merge the express-pouchdb one, get a green check here, and then +1.

yeah I tried to get all of the files on friday when I had some time, but ended up doing a huge commit to detached head of the wrong branch

+1 when green, see my comments in the express-pouchdb PR.

published express@0.5.3, but NPM is being very eventually consistent today

@calvinmetcalf Your express-pouchdb fix is in, but it's still failing due to this:

  1) test.bulk_docs.js-http Test errors on invalid doc id:

      correct error status returned
      + expected - actual

      +400
      -500

      at /home/travis/build/pouchdb/pouchdb/tests/test.bulk_docs.js:128:27
      at /home/travis/build/pouchdb/pouchdb/lib/utils.js:400:11
      at process._tickCallback (node.js:419:13)

woops typo on my part

@calvinmetcalf Still not passing...

did we publish the new version of express-pouchdb yet?

yeah

the one with 01183ff9357c99751d1da4733b2b8bdfdd888131?

err pouchdb/express-pouchdb@01183ff

this is the one that was supposed to fix it, no? pouchdb/express-pouchdb@487d01a

didn't fix it completely hence the other one, sometimes a 400 error would
return but it would get turned into a 500 error

On Sun, Aug 10, 2014 at 11:54 AM, Nolan Lawson notifications@github.com
wrote:

this is the one that was supposed to fix it, no? pouchdb/express-pouchdb@
487d01a
pouchdb/express-pouchdb@487d01a

—
Reply to this email directly or view it on GitHub
#2546 (comment).

-Calvin W. Metcalf

Those are both merged into master tho.

Ah crap need to publish. One sec.

b9d8644