Share chart data implementation between XSSFChart and XSLFChart through XDDF#68
Closed
Alain-Bearez wants to merge 28 commits intoapache:trunkfrom
cuali:xddf-usermodel
Closed
Share chart data implementation between XSSFChart and XSLFChart through XDDF#68Alain-Bearez wants to merge 28 commits intoapache:trunkfrom cuali:xddf-usermodel
Alain-Bearez wants to merge 28 commits intoapache:trunkfrom
cuali:xddf-usermodel
Conversation
|
A shame I decided to go with docx4j to implement a higher level charting library for pptx... We would have had a lot of common code to share. |
|
Can one of the admins verify this patch? |
onealj
approved these changes
Oct 31, 2017
Contributor
onealj
left a comment
There was a problem hiding this comment.
Skimming through the changes, looks good to me. I think this is a good idea!
Contributor
Author
Contributor
|
This PR looks good and ready to merge. We should probably have you sign a contributor license agreement before merging. I sent an email to your cua.li address with details. |
Member
|
CI also is green on commit de37f95, see https://builds.apache.org/view/P/view/POI/job/POI-Github-PullRequests/7/ |
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1816383 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this work is to be able to:
What is left to be done: