Closed
Conversation
Member
|
Thanks for the suggestion, this is applied now. Also updated JavaDoc a bit. Note: We prevent creation of sheets where the name only differs in upper-/lowercase, but a "broken" input file might lead to slightly different behavior after this, but we now handle this consistently across different formats. |
alexjansons
pushed a commit
to alexjansons/poi
that referenced
this pull request
Nov 23, 2024
We do not need to loop over all sheets always but should be able to return the first found sheet. This may change semantics for cases where there are multiple sheets where name only differs in case, but the JavaDoc did not state which one will be returned. All three implementations (HSSF, XSSF, SXSSF) now behave the same way. Closes apache#653 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918982 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.