Skip to content

MAXIFS, MINIFS, AVERAGEIFS - Implementation and Tests#242

Closed
jniewerth wants to merge 3 commits intoapache:trunkfrom
jniewerth:trunk
Closed

MAXIFS, MINIFS, AVERAGEIFS - Implementation and Tests#242
jniewerth wants to merge 3 commits intoapache:trunkfrom
jniewerth:trunk

Conversation

@jniewerth
Copy link

No description provided.

@centic9
Copy link
Member

centic9 commented Aug 13, 2021

Thanks for the contribution!

When I try to run tests on latest trunk with these changes I get three unit-test failures because of an NPE in Baseifs.java, can you take a look?

java.lang.NullPointerException at org.apache.poi.ss.formula.functions.Baseifs.accumulate(Baseifs.java:174) at org.apache.poi.ss.formula.functions.Baseifs.aggregateMatchingCells(Baseifs.java:157) at org.apache.poi.ss.formula.functions.Baseifs.evaluate(Baseifs.java:80) at org.apache.poi.ss.formula.functions.Countifs.evaluate(Countifs.java:31) at org.apache.poi.ss.formula.UserDefinedFunction.evaluate(UserDefinedFunction.java:59) at org.apache.poi.ss.formula.OperationEvaluatorFactory.evaluate(OperationEvaluatorFactory.java:140) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateFormula(WorkbookEvaluator.java:529) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:258) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluate(WorkbookEvaluator.java:199) at org.apache.poi.xssf.usermodel.BaseXSSFFormulaEvaluator.evaluateFormulaCellValue(BaseXSSFFormulaEvaluator.java:57) at org.apache.poi.ss.formula.BaseFormulaEvaluator.evaluate(BaseFormulaEvaluator.java:109) at org.apache.poi.ss.tests.formula.functions.TestCountifs.testBug56822(TestCountifs.java:118)

java.lang.NullPointerException at org.apache.poi.ss.formula.functions.Baseifs.accumulate(Baseifs.java:174) at org.apache.poi.ss.formula.functions.Baseifs.aggregateMatchingCells(Baseifs.java:157) at org.apache.poi.ss.formula.functions.Baseifs.evaluate(Baseifs.java:80) at org.apache.poi.ss.formula.functions.Countifs.evaluate(Countifs.java:31) at org.apache.poi.ss.formula.UserDefinedFunction.evaluate(UserDefinedFunction.java:59) at org.apache.poi.ss.formula.OperationEvaluatorFactory.evaluate(OperationEvaluatorFactory.java:140) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateFormula(WorkbookEvaluator.java:529) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:258) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluate(WorkbookEvaluator.java:199) at org.apache.poi.hssf.usermodel.HSSFFormulaEvaluator.evaluateFormulaCellValue(HSSFFormulaEvaluator.java:201) at org.apache.poi.ss.formula.BaseFormulaEvaluator.evaluate(BaseFormulaEvaluator.java:109) at org.apache.poi.ss.tests.formula.functions.TestCountifs.testCallFunction(TestCountifs.java:83)

java.lang.NullPointerException at org.apache.poi.ss.formula.functions.Baseifs.accumulate(Baseifs.java:174) at org.apache.poi.ss.formula.functions.Baseifs.aggregateMatchingCells(Baseifs.java:157) at org.apache.poi.ss.formula.functions.Baseifs.evaluate(Baseifs.java:80) at org.apache.poi.ss.formula.functions.Countifs.evaluate(Countifs.java:31) at org.apache.poi.ss.formula.UserDefinedFunction.evaluate(UserDefinedFunction.java:59) at org.apache.poi.ss.formula.OperationEvaluatorFactory.evaluate(OperationEvaluatorFactory.java:140) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateFormula(WorkbookEvaluator.java:529) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:258) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateReference(WorkbookEvaluator.java:785) at org.apache.poi.ss.formula.SheetRefEvaluator.getEvalForCell(SheetRefEvaluator.java:48) at org.apache.poi.ss.formula.SheetRangeEvaluator.getEvalForCell(SheetRangeEvaluator.java:74) at org.apache.poi.ss.formula.LazyRefEval.getInnerValueEval(LazyRefEval.java:39) at org.apache.poi.ss.formula.eval.OperandResolver.chooseSingleElementFromRef(OperandResolver.java:216) at org.apache.poi.ss.formula.eval.OperandResolver.getSingleValue(OperandResolver.java:64) at org.apache.poi.ss.formula.eval.RelationalOperationEval.evaluate(RelationalOperationEval.java:64) at org.apache.poi.ss.formula.functions.Fixed2ArgFunction.evaluate(Fixed2ArgFunction.java:31) at org.apache.poi.ss.formula.OperationEvaluatorFactory.evaluate(OperationEvaluatorFactory.java:138) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateFormula(WorkbookEvaluator.java:529) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateAny(WorkbookEvaluator.java:258) at org.apache.poi.ss.formula.WorkbookEvaluator.evaluateReference(WorkbookEvaluator.java:785) at org.apache.poi.ss.formula.SheetRefEvaluator.getEvalForCell(SheetRefEvaluator.java:48) at org.apache.poi.ss.formula.SheetRangeEvaluator.getEvalForCell(SheetRangeEvaluator.java:74) at org.apache.poi.ss.formula.LazyRefEval.getInnerValueEval(LazyRefEval.java:39) at org.apache.poi.ss.formula.EvaluationConditionalFormatRule.unwrapEval(EvaluationConditionalFormatRule.java:391) at org.apache.poi.ss.formula.EvaluationConditionalFormatRule.checkFormula(EvaluationConditionalFormatRule.java:401) at org.apache.poi.ss.formula.EvaluationConditionalFormatRule.matches(EvaluationConditionalFormatRule.java:330) at org.apache.poi.ss.formula.ConditionalFormattingEvaluator.getConditionalFormattingForCell(ConditionalFormattingEvaluator.java:182) at org.apache.poi.ss.tests.usermodel.TestConditionalFormattingEval.getRulesFor(TestConditionalFormattingEval.java:190) at org.apache.poi.ss.tests.usermodel.TestConditionalFormattingEval.testFormattingEvaluation(TestConditionalFormattingEval.java:120)

@asfgit asfgit closed this in 47d80f1 Aug 16, 2021
@pjfanning
Copy link
Member

thanks - merged using 47d80f1

snsinahub pushed a commit to snsinahub-org/poi that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants