Skip to content

Bugzilla 59623: code inspired from Axel Richter on StackOverflow#139

Closed
Alain-Bearez wants to merge 1 commit intoapache:trunkfrom
cuali:bugzilla-59623
Closed

Bugzilla 59623: code inspired from Axel Richter on StackOverflow#139
Alain-Bearez wants to merge 1 commit intoapache:trunkfrom
cuali:bugzilla-59623

Conversation

@Alain-Bearez
Copy link
Contributor

@Alain-Bearez Alain-Bearez commented Dec 27, 2018

In order to give an example of code for issue 59623, I reused three code examples from Axel Richter on StackOverflow:

  1. Create target marker in a bar chart with openxmlformats
  2. Change axis color and font of the chart in openxmlformats
  3. Change colors of line chart Apache POI

This led me to introduce and rewrite some internal code in the XDDF packages.

@asfgit
Copy link

asfgit commented Dec 27, 2018

Can one of the admins verify this patch?

pjfanning
pjfanning requested changes Dec 27, 2018
View reviewed changes
src/ooxml/java/org/apache/poi/xddf/usermodel/XDDFLineProperties.java
}

public Integer getWidth() {
public Double getWidth() {
Copy link
Member

@pjfanning pjfanning Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an API change - we probably need an ugly new getWidthAsDouble() and to deprecate the integer version

src/ooxml/java/org/apache/poi/xddf/usermodel/XDDFLineProperties.java
}

public void setWidth(Integer width) {
public void setWidth(Double width) {
Copy link
Member

@pjfanning pjfanning Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on API change

@asfgit
Copy link

asfgit commented Dec 28, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/2/

@Alain-Bearez
Copy link
Contributor Author

Alain-Bearez commented Dec 31, 2018

All classes in XDDF package are still annotated as @Beta.

As a matter of facts, several other properties that were defined as Integer should probably be converted to Double, such as:

XDDFLinearShadeProperties.java
    37: public Integer getAngle() { 
XDDFLineJoinMiterProperties.java
    41: public Integer getLimit() { 
XDDFLineProperties.java
     296: public Integer getWidth() { 
XDDFRelativeRectangle.java (4 matches)
    41: public Integer getBottom() { 
    59: public Integer getLeft() { 
    77: public Integer getRight() { 
    95: public Integer getTop() { 
XDDFTileInfoProperties.java (2 matches)
    65: public Integer getSx() { 
    83: public Integer getSy() { 
XDDFTransform2D.java
    123: public Integer getRotation() {

pjfanning
pjfanning approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok then to change these APIs. Could you mention the fact that you have changed some APIs in the release note?

@asfgit
Copy link

asfgit commented Apr 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/7/

@asfgit
Copy link

asfgit commented May 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/9/

@asfgit
Copy link

asfgit commented May 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/16/

@asfgit
Copy link

asfgit commented May 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/17/

@asfgit
Copy link

asfgit commented May 14, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/22/

@Alain-Bearez
Copy link
Contributor Author

Alain-Bearez commented May 14, 2019

In the release summary, I plan to mention that API has changed around angles and width units.

No further API changes are currently foreseen. Comment on December 31st was mentioning too many candidates.

@asfgit
Copy link

asfgit commented May 21, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/POI-DSL-Github-PullRequests/29/

@asfgit asfgit closed this in 5e070fd May 21, 2019
@Alain-Bearez Alain-Bearez deleted the bugzilla-59623 branch May 21, 2019 23:30
asfgit pushed a commit that referenced this pull request Oct 6, 2019
@Alain-Bearez
code inspired from Axel Richter on StackOverflow
9995e17 
closes #139
closes #144

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859676 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez pushed a commit to cuali/poi that referenced this pull request Dec 12, 2019
code inspired from Axel Richter on StackOverflow
76e558a 
closes apache#139
closes apache#144

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859676 13f79535-47bb-0310-9956-ffa450edef68
@tonyqus tonyqus mentioned this pull request Mar 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjfanning pjfanning pjfanning approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alain-Bearez @asfgit @pjfanning