Closed
Conversation
|
Can one of the admins verify this patch? |
centic9
reviewed
Dec 15, 2018
Member
centic9
left a comment
There was a problem hiding this comment.
CI build is running at https://builds.apache.org/view/P/view/POI/job/POI-Github-PullRequests/65/
src/java/org/apache/poi/ss/formula/functions/MultiOperandNumericFunction.java
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Dec 15, 2018
src/java/org/apache/poi/ss/formula/functions/AggregateFunction.java
Outdated
Show resolved
Hide resolved
Member
asfgit
pushed a commit
that referenced
this pull request
Oct 6, 2019
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849042 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…he#136 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849042 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested against Excel 2007 and according to MS Excel docs
All POI tests pass.
GeometricMean behavior for series containing zeros is handled.
There's also a change to MultiOperandNumeric function: now it handles MissingArgEvals (counts as 0).
It will make sense to squash the branch.