rename text segment class#110
Closed
pjfanning wants to merge 1 commit intoapache:trunkfrom
pjfanning:rename-text-segment
Closed
rename text segment class#110pjfanning wants to merge 1 commit intoapache:trunkfrom pjfanning:rename-text-segment
pjfanning wants to merge 1 commit intoapache:trunkfrom
pjfanning:rename-text-segment
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
+1 from me, XWPF is officially still in "scratchpad", please add an entry in status.xml which flags this as import change to have it properly documented in the changelog. |
asfgit
pushed a commit
that referenced
this pull request
May 27, 2018
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832354 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832352 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832354 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 4.0.0 release, it would be nice to fix the class name.
There aren't too many nice approaches to retaining compatibility for the old name of the class
TextSegement.