Skip to content

add back BackoffSupervisor.calculateDelay due to bin compat issues#2195

Merged
pjfanning merged 4 commits intoapache:1.2.xfrom
pjfanning:calc-delay-1.2
Sep 12, 2025
Merged

add back BackoffSupervisor.calculateDelay due to bin compat issues#2195
pjfanning merged 4 commits intoapache:1.2.xfrom
pjfanning:calc-delay-1.2

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 12, 2025

See apache/pekko-persistence-cassandra#305 and #1940

Aim for main branch is to forward fit the release note - and to move the mima filter to 2.0.x with a note about the bug in Pekko 1.2.0.

@pjfanning pjfanning added this to the 1.2.1 milestone Sep 12, 2025
@pjfanning pjfanning changed the base branch from main to 1.2.x September 12, 2025 13:52
@pjfanning pjfanning closed this Sep 12, 2025
@pjfanning pjfanning reopened this Sep 12, 2025
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@He-Pin He-Pin added the bug Something isn't working label Sep 12, 2025
*
* Calculates an exponential back off delay.
*
* Was removed in 1.2.0 but added back in 1.2.1 for binary compatibility reasons.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should point to the new methods in 2.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do - in the deprecation message below

@He-Pin
Copy link
Member

He-Pin commented Sep 12, 2025

Seems like some internal api is been used across akka projects :(

@pjfanning
Copy link
Member Author

Seems like some internal api is been used across akka projects :(

we can't assume package private code at [pekko] level is only used in this repo - it can be used in any of our repos

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pjfanning pjfanning merged commit 8d82a68 into apache:1.2.x Sep 12, 2025
9 checks passed
@pjfanning pjfanning deleted the calc-delay-1.2 branch September 12, 2025 15:37
@He-Pin
Copy link
Member

He-Pin commented Sep 12, 2025

seems like we will do a release soon

pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Sep 12, 2025
…pache#2195)

* add back BackoffSupervisor.calculateDelay due to bin compat issues

* Update BackoffSupervisor.scala

* Update releases-1.2.md

* Update BackoffSupervisor.scala
pjfanning added a commit that referenced this pull request Sep 12, 2025
* add back BackoffSupervisor.calculateDelay due to bin compat issues (#2195)

* add back BackoffSupervisor.calculateDelay due to bin compat issues

* Update BackoffSupervisor.scala

* Update releases-1.2.md

* Update BackoffSupervisor.scala

* remove deprecated method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants