Skip to content

chore: Remove the deprecated annotation from recoverWith#2119

Merged
He-Pin merged 1 commit intomainfrom
rec
Aug 31, 2025
Merged

chore: Remove the deprecated annotation from recoverWith#2119
He-Pin merged 1 commit intomainfrom
rec

Conversation

@He-Pin
Copy link
Member

@He-Pin He-Pin commented Aug 31, 2025

Motivation:
These methods are actually ok, the removal of deprecated is incomplete.

@He-Pin He-Pin requested a review from pjfanning August 31, 2025 06:25
@He-Pin He-Pin added this to the 2.0.0-M1 milestone Aug 31, 2025
@He-Pin He-Pin added the t:stream Pekko Streams label Aug 31, 2025
@He-Pin
Copy link
Member Author

He-Pin commented Aug 31, 2025

@pjfanning I want to backport this to 1.2.0 too

@pjfanning
Copy link
Member

I am not completely against undeprecating this. This has not been removed in main branch because something must still use it - but would it be feasible to check if the existing uses could with be changed to use recoverWithRetries?

@He-Pin
Copy link
Member Author

He-Pin commented Aug 31, 2025

The method is actually fine, you see I removed the depreciation in pekko and akka once, but I forgot some place

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 617d1c5 into main Aug 31, 2025
9 checks passed
@He-Pin He-Pin deleted the rec branch August 31, 2025 11:11
He-Pin added a commit that referenced this pull request Aug 31, 2025
He-Pin added a commit that referenced this pull request Aug 31, 2025
He-Pin added a commit that referenced this pull request Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:stream Pekko Streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants