Merged
Conversation
Contributor
Author
|
@tustvold This should help with the byte stream split PR I'll make soon |
Member
|
Should we link |
Contributor
Author
|
Yep, added it. I hadn't noticed the readme. |
pitrou
reviewed
Jan 9, 2024
| @@ -0,0 +1,27 @@ | |||
| `byte_stream_split.zstd.parquet` is generated by pyarrow 14.0.2 using the following code: | |||
Member
There was a problem hiding this comment.
Perhaps inline this in the README as for other files?
pitrou
reviewed
Jan 9, 2024
| 'f64': np.random.normal(size=300).astype(np.float64), | ||
| }) | ||
|
|
||
| f = '/Users/martin/Downloads/byte_stream_split.parquet' |
Member
There was a problem hiding this comment.
Just writing into the current directory would make this script more readily usable.
pitrou
reviewed
Jan 9, 2024
pitrou
reviewed
Jan 9, 2024
This was referenced Jan 11, 2024
pitrou
added a commit
to apache/arrow
that referenced
this pull request
Jan 11, 2024
…39570) ### Rationale for this change In apache/parquet-testing#45 , an integration file for BYTE_STREAM_SPLIT was added to the parquet-testing repo. ### What changes are included in this PR? Add a test reading that file and ensuring the decoded values are as expected. ### Are these changes tested? By definition. ### Are there any user-facing changes? No. * Closes: #39560 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…PLIT (apache#39570) ### Rationale for this change In apache/parquet-testing#45 , an integration file for BYTE_STREAM_SPLIT was added to the parquet-testing repo. ### What changes are included in this PR? Add a test reading that file and ensuring the decoded values are as expected. ### Are these changes tested? By definition. ### Are there any user-facing changes? No. * Closes: apache#39560 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow better testing of BYTE_STREAM_SPLIT encoding implementations.