Skip to content

PARQUET-133: Upgrade snappy-java to 1.1.1.6#85

Closed
xerial wants to merge 1 commit intoapache:masterfrom
xerial:PARQUET-133
Closed

PARQUET-133: Upgrade snappy-java to 1.1.1.6#85
xerial wants to merge 1 commit intoapache:masterfrom
xerial:PARQUET-133

Conversation

@xerial
Copy link
Copy Markdown
Contributor

@xerial xerial commented Nov 14, 2014

Upgrade snappy-java to 1.1.1.6 (the latest vesrion), since 1.0.5 is no longer maintained in https://github.com/xerial/snappy-java, and 1.1.1.6 supports broader platforms including PowerPC, IBM-AIX 6.4, SunOS, etc. And also it has a better native coding loading mechanism (allowing to use snappy-java from multiple class loaders)

@julienledem
Copy link
Copy Markdown
Member

this looks good to me.
@nongli @rdblue any comments?

@rdblue
Copy link
Copy Markdown
Contributor

rdblue commented Dec 2, 2014

The release notes for Snappy 1.1.0 include: "Upgrade to snappy-1.1.0". @xerial can you tell us more about this? I'm trying to figure out if there are any forward-incompatible changes to snappy brought in by this. If so, then I think we should wait until parquet-mr 2.x is released so we don't break old readers (allows version rollback).

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Dec 3, 2014

@rdblue
There is no forward-incompatible changes in API of 1.1.1.x, which adds the framing-format support to 1.0.x series.

@rdblue
Copy link
Copy Markdown
Contributor

rdblue commented Dec 3, 2014

@xerial, what is framing-format and when is it used? If it isn't forward-incompatible, then it must just be read-side support for this?

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Dec 4, 2014

@rdblue
Framing format (https://code.google.com/p/snappy/source/browse/trunk/framing_format.txt) is introduced for compressing large data set with less-memory usage. Since 1.1.1.x, snappy-java adds SnappyFramed{Input/Output}Stream for reading/writing this format, and there has been no extension in Snappy.{compress,uncompress} and Snappy{Input/Output}Stream classes.

I'm a little bit confused with the usage of the forward/backward compatibility. What I meant is there is no format change in what Snappy.compress/uncompress and SnappyInput/OutputStream produce since 1.0.x.

@rdblue
Copy link
Copy Markdown
Contributor

rdblue commented Dec 4, 2014

@xerial, thanks for clarifying, that's exactly what I was looking for. I just wanted to make sure there weren't changes to the way data would be written (without code changes in Parquet) that would prevent older readers from working. It sounds like the new format is contained in its own set of methods and classes, so I think we're okay.

+1

@julienledem
Copy link
Copy Markdown
Member

@rdblue do you want to merge?

@asfgit asfgit closed this in d7dd228 Jan 30, 2015
@rdblue
Copy link
Copy Markdown
Contributor

rdblue commented Jan 30, 2015

@julienledem done. @xerial thanks for the contribution!

dongche pushed a commit to dongche/incubator-parquet-mr that referenced this pull request Feb 3, 2015
Upgrade snappy-java to 1.1.1.6 (the latest vesrion), since 1.0.5 is no longer maintained in https://github.com/xerial/snappy-java, and 1.1.1.6 supports broader platforms including PowerPC, IBM-AIX 6.4, SunOS, etc. And also it has a better native coding loading mechanism (allowing to use snappy-java from multiple class loaders)

Author: Taro L. Saito <leo@xerial.org>

Closes apache#85 from xerial/PARQUET-133 and squashes the following commits:

01d7b78 [Taro L. Saito] PARQUET-133: Upgrade snappy-java to 1.1.1.6
gszadovszky pushed a commit to gszadovszky/parquet-mr that referenced this pull request Aug 22, 2018
add field_id in SchemaElement
gszadovszky pushed a commit to gszadovszky/parquet-mr that referenced this pull request Aug 22, 2018
https://issues.apache.org/jira/browse/PARQUET-1236

Author: 1028332163 <1028332163@qq.com>

Closes apache#85 from PandaMonkey/master and squashes the following commits:

158f082 [1028332163] align version of slf4j-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants