PARQUET-1807: Encryption: Interop and Function test suite for Java version#782
Merged
gszadovszky merged 14 commits intoapache:encryptionfrom Jun 10, 2020
Merged
Conversation
481818c to
44de61e
Compare
4 tasks
…rsion Depends on PR apache#776 for [PARQUET-1229] and on PR apache#12 in parquet-testing for [PARQUET-1807]. JIRA: https://issues.apache.org/jira/browse/PARQUET-1807 Add a test for writing and reading parquet in a number of encryption and decryption configurations. Add interop test that reads files from parquet-testing GitHub repository, that were written by parquet-cpp. This adds parquet-testing repo as a submodule. Run the following to populate the "submodules/parquet-testing/" folder: git submodule update --init --recursive
Add exclusion to rat license check for .gitmodules
…IndexFiltering according to Gabor's suggestion.
Address review comments - rename variables and move enums to top.
97b8667 to
a6162c5
Compare
…ests are already included in TestBloomFiltering and TestColumnIndexEncryption
gszadovszky
requested changes
Jun 2, 2020
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestBloomFiltering.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestColumnIndexFiltering.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you very much, @gszadovszky ! I'm on it. |
gszadovszky
requested changes
Jun 9, 2020
parquet-hadoop/src/test/java/org/apache/parquet/crypto/DecryptionKeyRetrieverMock.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java
Outdated
Show resolved
Hide resolved
gszadovszky
approved these changes
Jun 10, 2020
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Jul 15, 2020
…rsion (apache#782) Add a test for writing and reading parquet in a number of encryption and decryption configurations. Add interop test that reads files from parquet-testing GitHub repository, that were written by parquet-cpp. This adds parquet-testing repo as a submodule.
gszadovszky
pushed a commit
that referenced
this pull request
Jul 28, 2020
…rsion (#782) Add a test for writing and reading parquet in a number of encryption and decryption configurations. Add interop test that reads files from parquet-testing GitHub repository, that were written by parquet-cpp. This adds parquet-testing repo as a submodule.
gszadovszky
pushed a commit
that referenced
this pull request
Jul 29, 2020
* PARQUET-1228: Format Structures encryption (#613) * PARQUET-1286: Crypto package (#614) * PARQUET-1818: Fix bloom/encryption collision in format-structures (#771) * PARQUET-1817: Crypto Properties Factory (#769) * PARQUET-1229: Parquet MR encryption (#776) * PARQUET-1807: Encryption: Interop and Function test suite for Java version (#782) * PARQUET-1373: Encryption key tools (#615) Co-authored-by: shangxinli <31421745+shangxinli@users.noreply.github.com> Co-authored-by: Maya Anderson <mayaa@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/PARQUET-1807
Depends on: PR #776 PARQUET-1229: Parquet MR encryption (merged) and
on PR #12 PARQUET-1834: Add Apache 2.0 license to README.md files in parquet-testing (merged).
Add a test for writing and reading parquet in a number of encryption and decryption configurations.
Add interop test that reads files from parquet-testing GitHub repository, that were written by parquet-cpp.
This adds parquet-testing repo as a submodule in the "submodules/parquet-testing/" folder.
A new script dev/submodule-update.sh clones missing submodules during maven build.
Co-authored-by: Revital Eres eres@il.ibm.com