Skip to content

Code cleanup for csl.editor.semantic package#8028

Merged
lkishalmi merged 1 commit intoapache:masterfrom
lkishalmi:csl-highlighter-fix-2
Dec 11, 2024
Merged

Code cleanup for csl.editor.semantic package#8028
lkishalmi merged 1 commit intoapache:masterfrom
lkishalmi:csl-highlighter-fix-2

Conversation

@lkishalmi
Copy link
Copy Markdown
Contributor

Fixes and cleanups form #8011 and more.

@lkishalmi lkishalmi added CSL [ci] enable web job Editor labels Dec 8, 2024
@lkishalmi lkishalmi added this to the NB25 milestone Dec 8, 2024
@mbien mbien added the Code cleanup Label for cleanup done on the Netbeans IDE label Dec 9, 2024
Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minimal nitpick, apart from that looks sane.

@lkishalmi lkishalmi force-pushed the csl-highlighter-fix-2 branch from 7207278 to 0ba2e7a Compare December 11, 2024 19:17
Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lkishalmi lkishalmi merged commit 0b4ca34 into apache:master Dec 11, 2024
junichi11 added a commit to junichi11/netbeans that referenced this pull request Dec 13, 2024
- Do not return `null` in `getOccurrences()`
- See apacheGH-8028
@junichi11 junichi11 mentioned this pull request Dec 13, 2024
junichi11 added a commit to junichi11/netbeans that referenced this pull request Dec 18, 2024
- See the changes in apacheGH-8028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code cleanup Label for cleanup done on the Netbeans IDE CSL [ci] enable web job Editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants