Fix MacOS tests failures in java.hints#7926
Merged
lahodaj merged 1 commit intoapache:masterfrom Oct 30, 2024
Merged
Conversation
Contributor
|
I would suggest to drop the |
The javac outputs of the following tests in java/java.hints ErrorHintsProviderTest were updated for non-mac OSes due to changes in JDK 7 updates: - testShortErrors5: [jdk-6968793](openjdk/jdk@b77effad6c6) - testTestShortErrorsSVUIDWarning: [jdk-6957438](openjdk/jdk@1c75e97108) Since Apple JDK was present only up till JDK 6, we no longer require the special case for MacOS since JDK 8. Thus, making the test argument value `specialMacTreatment = false` for these two tests, and renaming the corresponding goldenfiles from "-nonmac.pass" suffix to ".pass" suffix. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
c97051d to
daf79f9
Compare
Contributor
Author
Thank you @lahodaj. I've removed the old files and pushed the commit again. |
lahodaj
approved these changes
Oct 30, 2024
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Member
|
awesome, thanks! |
Achal1607
pushed a commit
to Achal1607/netbeans
that referenced
this pull request
Feb 21, 2025
Adding the patch for the netbeans PR apache#7926 to fix the unit test failures in the java.hints module due to old Apple JDK 6 special treatment for the expected output. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The javac outputs of the following tests in java/java.hints ErrorHintsProviderTest were updated for non-mac OSes due to changes in JDK 7 updates:
Since Apple JDK was present only up till JDK 6, we no longer require the special case for MacOS since JDK 8.
Thus, making the test argument value
specialMacTreatment = falsefor these two tests, and renaming the corresponding goldenfiles from "-nonmac.pass" suffix to ".pass" suffix, while retaining the original mac goldenfiles with the "-oldmac.pass" suffix.