[NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon#1501
Merged
lkishalmi merged 4 commits intoapache:masterfrom Sep 15, 2019
Merged
[NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon#1501lkishalmi merged 4 commits intoapache:masterfrom
lkishalmi merged 4 commits intoapache:masterfrom
Conversation
junichi11
reviewed
Sep 13, 2019
groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Sep 13, 2019
groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Sep 13, 2019
groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
Outdated
Show resolved
Hide resolved
Member
|
@lkishalmi I'm not familiar with this area but just left a few comments. Thanks. |
203efb5 to
9be88ba
Compare
junichi11
reviewed
Sep 14, 2019
groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take over #1425 as it seems to be abandoned, in order to be released in 11.2.