[NETBEANS-3041] Add gradle support org.gradle.jvmargs #1425
[NETBEANS-3041] Add gradle support org.gradle.jvmargs #1425one-leaf wants to merge 3 commits intoapache:masterfrom
Conversation
|
@one-leaf Did you read this? https://netbeans.apache.org/participate/submit-pr.html |
Yes. I've read it. |
|
@one-leaf Why didn't you create a new ticket[1] and a branch?? |
lkishalmi
left a comment
There was a problem hiding this comment.
Also do not forget to increment the implementation version.
The JIRA issue is still required, and this PR shall be labelled as API Change.
Other than that, it is a nice piece of work. Thanks!
| } | ||
| projectDir = dir; | ||
| rootDir = projectDir; | ||
| searchPropertyFiles(); |
There was a problem hiding this comment.
Probably it would be better to calculate the property files whenever the getPropertFiles() call is made, also it shall it shall not be stored as a member variable. It also shall return an empty array if the GradleFiles does not represent a project folder. Also the returned list shall be immutable.
It seems I've totally forgotten to implement that method. Thanks for doing that.
| } | ||
| } | ||
|
|
||
| public void configure(ConfigurableLauncher launcher, File projectDir) { |
There was a problem hiding this comment.
This is API change, shall be documented with at least a @since
|
@one-leaf In the meantime this issue has been reported as (NETBEANS-3041)[https://issues.apache.org/jira/browse/NETBEANS-3041] So do not worry about that. Are you able to make the requested changes or shall I take over this PR? |
|
Closing in favor of #1501 |
add read jvmargs from gradle.properties.