Closed
Conversation
chrysn
added a commit
to chrysn-pull-requests/RIOT
that referenced
this pull request
Jan 4, 2025
This is now in apache/mynewt-nimble#1956
sjanc
reviewed
Jan 7, 2025
| void | ||
| nimble_port_init(void) | ||
| { | ||
| ble_ll_init(); |
Contributor
There was a problem hiding this comment.
I'd suggest to call it after os_msys_init()
Contributor
There was a problem hiding this comment.
oh, and it should also be under
#if NIMBLE_CFG_CONTROLLER
Contributor
|
Hi, Any chance to get this PR fixed? If not I can fix it myself (we would really like to get RIOT port working again against latest releases) |
Contributor
|
fixed upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the RIOT port, when upgrading from 0.15 to 0.18, I had to manually call ble_ll_init; as per a comment from @sjanc, this is better done in the nimble_port_init call, where this PR moves it.
This is being tested in RIOT, where the patch is being applied in the 0.18 branch.