Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Mar 8, 2020

@elharo elharo requested a review from michael-o March 8, 2020 18:53
* <p>
* Class that abstracts the Shell functionality,
* with subclases for shells that behave particularly, like
* with subclasses for shells that behave particularly, like</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc 8 will probably bug you for this. They expect <p> only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

/**
* <p>
* Implementation to call the CMD Shell present on Windows NT, 2000 and XP
* Implementation to call the CMD Shell present on Windows NT, 2000, X, 7, and 10.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X => XP
As well as Windows 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*
* @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
*
* @deprecated Windows Me is long dead. Update to Windows 10 and use {@link CmdShell}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was Windows ME. Horrible OS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit cb448b9 into master Mar 12, 2020
@elharo elharo deleted the winme branch March 12, 2020 14:54
@jira-importer
Copy link

Resolve #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants