future proof method that is marked for incompatible change #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisl
requested changes
Jul 21, 2020
Contributor
dennisl
left a comment
There was a problem hiding this comment.
When platform encoding is being used, this change removed it from being printed to the log. This is useful ingformation to users that don't know what encoding is being used.
This can be accessed by simply calling "System.getProperty( "file.encoding" )" instead of "ReaderFactory.FILE_ENCODING".
Contributor
Author
|
Is it useful though? The relevant detail is that the platform default is being used. The point is that whatever value that is, and which we would print here, is not reliable or consistent. |
Contributor
|
In my experience it is very useful. When moving a project from being built locally by developers to a CI solution, developers are often surprised when they don't get the same results there. |
Contributor
Author
|
Yes, and when that happens they should sit down and figure out which encoding they should use (usually UTF-8). They should not simply copy and paste whichever encoding they happened to be using by accident like they're writing a characterization test to mimic the idiosyncratic behavior of their development box. |
Contributor
|
If their build is failing, then knowing the encoding that was used gives
them a hint about what not to use.
|
elharo
commented
Jul 23, 2020
Contributor
Author
elharo
left a comment
There was a problem hiding this comment.
OK, added the encoding back in
This was referenced Mar 8, 2021
|
Resolve #284 |
lfit-replication
pushed a commit
to lfit/sandbox
that referenced
this pull request
Dec 3, 2025
…m 2.6 to 3.3.1 Bumps org.apache.maven.plugins:maven-resources-plugin from 2.6 to 3.3.1. ## Release notes Sourced from org.apache.maven.plugins:maven-resources-plugin's releases. 3.3.1 [MRESOURCES-288] - Make tests-jar reproducible (#56) @cstamas [MRESOURCES-297] - Update to parent POM 39, reformat (#55) @cstamas [MRESOURCES-293] - Make resources param not read-only (#54) @cstamas [MRESOURCES-295] - Drop Plexus legacy code (#53) @cstamas [MRESOURCES-294] - Upgrade plexus-utils to 3.5.1 (#52) @slachiewicz 🚨 Removed remove specific IDE m2e files (#40) @olamy 📦 Dependency updates Bump apache/maven-gh-actions-shared from 2 to 3 (#46) @dependabot 📝 Documentation updates doc: adds alternative variable syntax using @ delimiters to the documentation (#36) @kevin0x90 3.3.0 📦 Dependency updates Bump maven-filtering from 3.2.0 to 3.3.0 (#32) @dependabot Bump plexus-utils from 3.4.1 to 3.4.2 (#28) @dependabot Bump commons-io from 1.4 to 2.7 in /src/it/user-filters (#18) @dependabot [MRESOURCES-282] - Bump parent-pom from 34 to 36 (#24) @slachiewicz 📝 Documentation updates (doc) Fix XML formatting (#26) @pzygielo (doc) Fix XML formatting (#15) @pzygielo 👻 Maintenance add release drafter (#29) @olamy [MRESOURCES-277] - Update plugin (requires Maven 3.2.5+) - Java 8 (#23) @slachiewicz [MRESOURCES-283] - Require Java 8 and upgrade deps (#22) @slachiewicz 3.2.0 What's Changed [MRESOURCES-259] update commons-io by @elharo in apache/maven-resources-plugin#1 add .checkstyle to .gitignore by @elharo in apache/maven-resources-plugin#2 close file by @elharo in apache/maven-resources-plugin#3 [MRESOURCES-261] update to Maven 3.1 by @elharo in apache/maven-resources-plugin#4 try with resources by @elharo in apache/maven-resources-plugin#5 future proof method that is marked for incompatible change by @elharo in apache/maven-resources-plugin#6 New Contributors ... (truncated) ## Commits 978ce1e [maven-release-plugin] prepare release maven-resources-plugin-3.3.1 b7cd080 [MRESOURCES-296] Upgrade to maven-filtering 3.3.1 1c9f610 [MRESOURCES-288] Make tests-jar reproducible (#56) 1946127 [MRESOURCES-293] Rollback f7a6f22 [MRESOURCES-297] Update to parent POM 39, reformat (#55) 22d64ca remove specific IDE m2e files (#40) 02c2d01 [MRESOURCES-293] Make resources param not read-only (#54) 6bb3e1f [MRESOURCES-295] Drop Plexus legacy code (#53) df7e172 [MRESOURCES-294] Upgrade plexus-utils to 3.5.1 9354ecd Bump apache/maven-gh-actions-shared from 2 to 3 Additional commits viewable in compare view  Issue-ID: CIMAN-33 Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: lfit.gh2gerrit <releng+lfit-gh2gerrit@linuxfoundation.org> Change-Id: I7ec3f0f8fb35c0771c23e8199cea48b265706f0b GitHub-PR: #23 GitHub-Hash: d4984246f920c32a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and generally be explicit about which dependencies this depends on