Include "[ci skip]" by default in scmReleaseCommitComment #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5231b18 to
2372081
Compare
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Outdated
Show resolved
Hide resolved
2372081 to
3ce9b6c
Compare
Member
Author
|
Now I just need to make GitHub build this branch (despite containing "[ci skip]" in the commit message)... |
Member
😄 try simple |
This leads to skipping this commit from auto-building with most CI/CD systems. Compare with https://docs.github.com/en/actions/how-tos/manage-workflow-runs/skip-workflow-runs, https://docs.gitlab.com/ci/pipelines/#skip-a-pipeline and https://plugins.jenkins.io/scmskip/ This closes #1422
3ce9b6c to
8ba52a1
Compare
Member
Author
|
Let's trust the Jenkins build in this case |
slawekjaranowski
approved these changes
Nov 19, 2025
Member
slawekjaranowski
left a comment
There was a problem hiding this comment.
Should we mark this change as braking ... to point about check by users during upgrade
Member
|
@kwin I can release next version in a few days after my PR merge ... |
|
CI skipping is for things like trivial typos, not the release version of software. If there's a problem with a particular CI implementation when building release versions it should be resolved in that CI build, don't disable CI for everyone who performs releases of software built using Maven's built-in release plugin. |
rvesse
added a commit
to rvesse/maven-release
that referenced
this pull request
Dec 8, 2025
This reverts PR apache#1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
8 tasks
rvesse
added a commit
to rvesse/maven-release
that referenced
this pull request
Dec 9, 2025
This reverts PR apache#1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
kwin
pushed a commit
that referenced
this pull request
Dec 9, 2025
This reverts PR #1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to skipping this commit from auto-building with most CI/CD systems.
Compare with
https://docs.github.com/en/actions/how-tos/manage-workflow-runs/skip-workflow-runs, https://docs.gitlab.com/ci/pipelines/#skip-a-pipeline and https://plugins.jenkins.io/scmskip/
This closes #1422
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.