[MNG-6957] support build/consumer with modules in reverse order #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modules are aggregated in reverse order
… modules are aggregated in reverse order
mthmulders
approved these changes
Nov 28, 2020
michael-o
reviewed
Nov 28, 2020
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6957BuildConsumer.java
Outdated
Show resolved
Hide resolved
Member
|
There is a problem with this branch where not all LF ending fixes from me where properly merged. I need to care of this before I can continue testing. |
Member
|
I read the article before, I do like it. It is worth adding! |
mthmulders
reviewed
Dec 16, 2020
core-it-suite/src/test/resources/mng-6957-buildconsumer/expected/simple-parent.pom
Show resolved
Hide resolved
Member
|
Looking back at this again.... |
michael-o
requested changes
Dec 20, 2020
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5576CdFriendlyVersions.java
Show resolved
Hide resolved
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6957BuildConsumer.java
Outdated
Show resolved
Hide resolved
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6957BuildConsumer.java
Outdated
Show resolved
Hide resolved
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6957BuildConsumer.java
Outdated
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/expected/parent.pom
Outdated
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/simple-parent/simple-testutils/pom.xml
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/simple-parent/simple-weather/pom.xml
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/simple-parent/simple-webapp/pom.xml
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/simple-parent/simple-webapp/pom.xml
Show resolved
Hide resolved
core-it-suite/src/test/resources/mng-6957-buildconsumer/simple-parent/utils-parent/pom.xml
Show resolved
Hide resolved
michael-o
approved these changes
Dec 21, 2020
Member
michael-o
left a comment
There was a problem hiding this comment.
No objections anymore. Please squash. Be very caseful with the merge. It seems that your branch hasn't been made from a fresh clone. I still see line ending issues. If you are unsure, please squash and I will take care of them.
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2020
…f modules are aggregated in reverse order This closes #82
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2020
…f modules are aggregated in reverse order This closes #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.