Skip to content

Introduce ChangeDetection#323

Merged
cstamas merged 12 commits intomaven-filtering-3.xfrom
maven-filtering-3.x-issue-453
Feb 26, 2026
Merged

Introduce ChangeDetection#323
cstamas merged 12 commits intomaven-filtering-3.xfrom
maven-filtering-3.x-issue-453

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Feb 19, 2026

Instead to jump between ways how to perform "change detection" (decide should existing target file be overwritten), make it a configurable strategy.

Before 3.4.0 it was timestamp, post 3.4.0 it was content, but in any case users were left short.

Fixes
apache/maven-resources-plugin#453
#321
#271

Instead to jump between ways how to perform "change detection"
(decide should existing target file be overwritten), make it
a configurable strategy.

Before 3.4.0 it was timestamp, post 3.4.0 it was content, but
in any case users were left short.

Fixes
apache/maven-resources-plugin#453
@cstamas cstamas self-assigned this Feb 19, 2026
@cstamas cstamas marked this pull request as ready for review February 19, 2026 20:42
@cstamas cstamas added the enhancement New feature or request label Feb 19, 2026
@cstamas cstamas linked an issue Feb 19, 2026 that may be closed by this pull request
@cstamas cstamas linked an issue Feb 19, 2026 that may be closed by this pull request
}
}
}
copyFilePermissions(from, to);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is confusing me: to me it sounds like if copied then apply perms, but we have UT that ensures perms are always copied...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, i missed at method beginning: we modify perms

It simply copied if target does not exists, and stands off
if target exists.
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cstamas cstamas merged commit d9bc10a into maven-filtering-3.x Feb 26, 2026
27 checks passed
@cstamas cstamas deleted the maven-filtering-3.x-issue-453 branch February 26, 2026 12:19
@github-actions github-actions bot added this to the 3.4.1 milestone Feb 26, 2026
cstamas added a commit to apache/maven-resources-plugin that referenced this pull request Feb 26, 2026
Use the change detection strategy from maven-filtering

Depends on apache/maven-filtering#323

Fixes #453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FilteringUtils always copies file while comment says otherwise [MSHARED-1360] Remove apache commons dependencies

2 participants